[#4999] feat(catalog): make cloud.name and cloud.region-code mutable.
#5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindaSummer
force-pushed
the
feature/cloud-confiog-mutable
branch
from
0d5be79 to
95c6964
Compare
LindaSummer
force-pushed
the
feature/cloud-confiog-mutable
branch
from
95c6964 to
b55b667
Compare
mchades
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make catalog property
cloud.nameandcloud.region-codemutable.Why are the changes needed?
As #4999 mentioned, the
cloud.nameandcloud.region-codemay change after first creation.Fix: #4999
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Related integration tests have been added in this PR.