[#4981] Improvement(test): Add integration tests for Hive catalog with S3 location. #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not ready for review until #4980 is merged. |
yuqi1129
changed the title
yuqi1129
changed the title
jerryshao
reviewed
Sep 23, 2024
yuqi1129
commented
Sep 23, 2024
| * container with S3 is Hive3 container and the Hive container is Hive2 container. There is | ||
| * something wrong with the hive2 container to access the S3. | ||
| */ | ||
| private static volatile HiveContainer hiveContainerWithS3; |
There was a problem hiding this comment.
We cannot share the container even if we uniform the hive version to hive3 for the following reasons.
- We need to ensure the s3 environment is ready before starting the Hive container so we can share it.
- for the reason in #(1, we need to start localstack(S3 simulator) first, however we can't make sure
CatalogHiveS3ITwas the first one to execute.
|
I'm OK with this PR itself. But I think compared to IT, it is more valuable to add some docs to claim that this can be run on S3 and walk users to some references about how to configure Hive on S3, that should be enough. |
Got it, it's not a big deal to add a document reference about it and I'll do it today. |
jerryshao
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add integration tests to test hive catalog with S3 location.
Why are the changes needed?
To make code more robust.
Fix: #4981
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
The changes itself is tested.