Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method #4971

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

yangyuxia
Copy link
Contributor

What changes were proposed in this pull request?

put the check code into the code block Utils.doAs.

Why are the changes needed?

Fix: #4960

Does this PR introduce any user-facing change?

Passing identity authentication information when checking hive resource

How was this patch tested?

yes,finish functional test By hand, based on the hive meatasotre with kerberos authentication enabled

…checking whether securable object exists in createRole() method
@jerqi
Copy link
Contributor

jerqi commented Sep 20, 2024

@yangyuxia

  1. Maybe this pull request is solved two issues. First, checks whether securable object exists in createRole() method. Second, the interacts with Ranger. Could you raise an another pull request to solve the second issue?
  2. Could you modify the title from [apache#4960] to [#4960]?

@yangyuxia yangyuxia changed the title [apache#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method Sep 20, 2024
@yangyuxia yangyuxia closed this Sep 20, 2024
@yangyuxia yangyuxia reopened this Sep 20, 2024
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi closed this Sep 20, 2024
@jerqi jerqi reopened this Sep 20, 2024
@jerqi jerqi closed this Sep 20, 2024
@jerqi jerqi reopened this Sep 20, 2024
@jerryshao jerryshao merged commit ca8d801 into apache:main Sep 20, 2024
57 of 58 checks passed
@jerryshao
Copy link
Contributor

I think this problem also exists in branch-0.6, @yangyuxia would you please cherry-pick this commit and create a same PR against branch-0.6? Thanks.

jerryshao pushed a commit to jerryshao/gravitino that referenced this pull request Sep 21, 2024
…checking whether securable object exists in createRole() method (apache#4971)

### What changes were proposed in this pull request?

put the check code into the code block Utils.doAs.

### Why are the changes needed?

Fix: apache#4960 

### Does this PR introduce _any_ user-facing change?

Passing identity authentication information when checking hive resource

### How was this patch tested?

yes,finish functional test By hand, based on the hive meatasotre with
kerberos authentication enabled

Co-authored-by: yangyx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Hive metastore authentication failed when creating a role
3 participants