[#4890] improvement(IT): Add the Integration Tests for getFileLocation interface
#4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao Please take a look of this PR when you have time, thanks. |
jerryshao
reviewed
Sep 12, 2024
clients/client-java/src/test/java/org/apache/gravitino/client/integration/test/FilesetIT.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Sep 12, 2024
| String actualFileLocation = | ||
| catalog.asFilesetCatalog().getFileLocation(filesetIdent, "/test2.par"); | ||
|
|
||
| Assertions.assertEquals(expectedFileset.storageLocation() + "/test2.par", actualFileLocation); |
There was a problem hiding this comment.
I don't see you verify the CallerContext in the server side, can you please add some tests about this?
There was a problem hiding this comment.
Add a test case in the server-side unit test.
jerryshao
reviewed
Sep 12, 2024
| @@ -268,7 +269,7 @@ public Response getFileLocation( | |||
| catalog, | |||
| schema, | |||
| fileset, | |||
| subPath); | |||
| RESTUtils.decodeString(subPath)); | |||
There was a problem hiding this comment.
Can you please add the test to cover the scenario that path should be encoded and decoded?
There was a problem hiding this comment.
Make the server-side encode/decode unit test more complete. In addition, the current integration test also covers the normal situation of encode/decode, otherwise the actualFileLocation returned by the server cannot match the Location expected by the client.
jerryshao
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the integration Tests for
getFileLocationinterface and fix some issues.Why are the changes needed?
Fix: #4890
How was this patch tested?
Add some ITs.