Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(jdbc-catalog):Add code skeleton for oceanbase-ce jdbc catalog #4918

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

yuanoOo
Copy link
Contributor

@yuanoOo yuanoOo commented Sep 11, 2024

What changes were proposed in this pull request?

  • add catalog-jdbc-oceanbase module
  • add code skeleton for oceanbase-ce jdbc catalog

Why are the changes needed?

Fix: #4916

Does this PR introduce any user-facing change?

no

How was this patch tested?

build pass. tests will be added in implementation PRs

@yuanoOo
Copy link
Contributor Author

yuanoOo commented Sep 11, 2024

@mchades PTAL.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz remove implementation in this PR since it's for code skeleton only

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions!

I'm going to merge this PR, and I think the next PR should be support schema operations for oceanbase catalog

@yuanoOo
Copy link
Contributor Author

yuanoOo commented Sep 19, 2024

OK, I will create a subtask issue to track the upcoming schema operation PR.

@mchades mchades merged commit 7c10cde into apache:main Sep 19, 2024
26 checks passed
@yuanoOo yuanoOo deleted the oceanbase-code-skeleton branch September 24, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add code skeleton for OceanBase-CE JDBC catalog
2 participants