-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(jdbc-catalog):Add code skeleton for oceanbase-ce jdbc catalog #4918
Conversation
@mchades PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz remove implementation in this PR since it's for code skeleton only
...eanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/OceanBaseCatalogCapability.java
Show resolved
Hide resolved
...a/org/apache/gravitino/catalog/oceanbase/converter/OceanBaseColumnDefaultValueConverter.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/gravitino/catalog/oceanbase/converter/OceanBaseTypeConverter.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseDatabaseOperations.java
Show resolved
Hide resolved
...src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
Outdated
Show resolved
Hide resolved
catalogs/catalog-jdbc-oceanbase/src/test/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contributions!
I'm going to merge this PR, and I think the next PR should be support schema operations for oceanbase catalog
OK, I will create a subtask issue to track the upcoming schema operation PR. |
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #4916
Does this PR introduce any user-facing change?
no
How was this patch tested?
build pass. tests will be added in implementation PRs