Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4246] improvement(core): Remove role local cache #4901

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

lw-yang
Copy link
Contributor

@lw-yang lw-yang commented Sep 10, 2024

What changes were proposed in this pull request?

Remove role local cache

Why are the changes needed?

Fix: #4246

Does this PR introduce any user-facing change?

/

How was this patch tested?

exist ut

@lw-yang
Copy link
Contributor Author

lw-yang commented Sep 10, 2024

@jerqi please help review it when you feee

@jerqi
Copy link
Contributor

jerqi commented Sep 10, 2024

Do you need to update the document, too?

@lw-yang
Copy link
Contributor Author

lw-yang commented Sep 10, 2024

yes, i forget it, i will update it

@lw-yang
Copy link
Contributor Author

lw-yang commented Sep 10, 2024

@jerqi I haven't found any doc about role cache

@jerqi
Copy link
Contributor

jerqi commented Sep 10, 2024

@jerqi I haven't found any doc about role cache

OK, we can remove it directly.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi
Copy link
Contributor

jerqi commented Sep 12, 2024

@yuqi1129 Could you help review this pull request?

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit 252b911 into apache:main Sep 12, 2024
31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
### What changes were proposed in this pull request?

Remove role local cache

### Why are the changes needed?

Fix: #4246 

### Does this PR introduce _any_ user-facing change?

/

### How was this patch tested?

exist ut

Co-authored-by: Qi Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Local cache should be turned off by default
3 participants