[draf] unify drop catalog and metalake #4883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
force-pushed
the
unify-drop-mc
branch
from
c07bf86 to
73487fe
Compare
|
@jerryshao Could you please review the new API definition when you have time? Thank you. |
jerryshao
reviewed
Sep 18, 2024
| * @throws NonEmptyEntityException If the catalog is not empty. | ||
| * @throws EntityInUseException If the catalog is in use. | ||
| */ | ||
| boolean dropCatalog(NameIdentifier ident) throws NonEmptyEntityException, EntityInUseException; |
There was a problem hiding this comment.
We should use String catalog name, not catalog name identifier.
jerryshao
reviewed
Sep 18, 2024
| */ | ||
| boolean dropCatalog(String catalogName); | ||
| void inactivateCatalog(NameIdentifier ident) throws NoSuchCatalogException; |
There was a problem hiding this comment.
deactivate, not inactivate.
|
I need to think more about it, generally the API design LGTM. |
|
I will close this PR, the rest of the tasks will be tracked by #5031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
in-useproperty to metalake and catalogin-useto drop catalog/metalake APIsinactivate()andactivate()API for metalake and catalogWhy are the changes needed?
unify drop catalog and metalake
Does this PR introduce any user-facing change?
yes
How was this patch tested?
tests added