[#4860] improvement(core): Add a skeleton for EntityStore #4861
Conversation
| * @param type RelationType of the relationship. | ||
| * @throws AlreadyExistsException if the relation already exists. | ||
| */ | ||
| void addRelation( |
There was a problem hiding this comment.
Do we support to override relation?
There was a problem hiding this comment.
I analyzed the current call chain and it doesn't seem necessary to add an update interface. In order to make it more extensive, I agree at it's more preferable to add an update funtionity.
| * @return List of MetadataObject that are related to the starting point. | ||
| * @throws IOException if the list operation fails. | ||
| */ | ||
| List<MetadataObject> listMetadataObjectsByRelation( |
There was a problem hiding this comment.
What's the difference between listEntitiesByRelation and listMetadataObjectsByRelation?
There was a problem hiding this comment.
They are utilized in different scenarios.
listEntitiesByRelationis used to list all entities by a relation, all these entities should be with the same type, for example, there can be allmetalakeorcatalogs, currently we can't get a bundle of entities with different entity types.listMetadataObjectsByRelationhandles the case thatlistEntitiesByRelationcan't cope with and only returns entities identifier.
Do you have any good suggestions for merging these two, I'm also trying to combine them, the current solution is not so elegant.
There was a problem hiding this comment.
@jerqi
Currently the concepts of Entity and MetadataObject are quite different, and I can hardly find a good way to merge them.
There was a problem hiding this comment.
In my opinion, we don't need to have the concept of metadata object in the EntityStore. The metadata object is a upper level concept.
There was a problem hiding this comment.
So we directly load the entity and then convert it to MetadataObject? If so, it's very heavy when loading/listing metadataobjects.
There was a problem hiding this comment.
It's ok for me. The convert is the memory operation.
There was a problem hiding this comment.
Okay, let me review it again.
What changes were proposed in this pull request?
Propose a new interface for
EntityStorebased on https://docs.google.com/document/d/11I-qyXrarQhCMZXoI5d1z5OEt8UlrpHm6Ix07DOuL4Y/edit#heading=h.vs40sx9ghyu2Why are the changes needed?
The current
EntityStoreis not elegant enough.Fix: #4840
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A.