[#4845] fix(core): Fix bugs when updating metalake or catalog with nullable comment. #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have similar issue for "topic"? |
This problem only occurs in conditions like where or on predicate and the root cause is will return false. The update method for "topic" is |
|
This PR is an improvement for #4541. |
jerryshao
reviewed
Sep 4, 2024
| @@ -150,7 +150,8 @@ CatalogPO selectCatalogMetaByMetalakeIdAndName( | |||
| + " AND metalake_id = #{oldCatalogMeta.metalakeId}" | |||
| + " AND type = #{oldCatalogMeta.type}" | |||
| + " AND provider = #{oldCatalogMeta.provider}" | |||
| + " AND catalog_comment = #{oldCatalogMeta.catalogComment}" | |||
| + " AND (catalog_comment = #{oldCatalogMeta.catalogComment} " | |||
| + " or (catalog_comment is null and #{oldCatalogMeta.catalogComment} is null))" | |||
There was a problem hiding this comment.
Can you please change to "IS NULL" for reserved words?
jerryshao
approved these changes
Sep 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…llable comment. (#4846) ### What changes were proposed in this pull request? Change the update SQL in the mapper to handle nullable comment. ### Why are the changes needed? It's a bug to fix. Fix: #4845 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Added UTs and ITs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the update SQL in the mapper to handle nullable comment.
Why are the changes needed?
It's a bug to fix.
Fix: #4845
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Added UTs and ITs