[#4779] Improvement(trino-connector): Add the testset for the Iceberg catalog with jdbc backend #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Sep 5, 2024
| @@ -1,78 +1,78 @@ | |||
| CREATE SCHEMA gt_iceberg.gt_db2; | |||
There was a problem hiding this comment.
Why do we remove the catalog prefix?
There was a problem hiding this comment.
I need to reuse this tests for the Iceberg catalog with the JDBC backend and HMS backend, So the catalog name should removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the testset for the Iceberg catalog with jdbc backend, it reuse the Hive metastore backend testset
Why are the changes needed?
Fix: #4779
Does this PR introduce any user-facing change?
NO
How was this patch tested?
New It