[#4657] Improvement (docs): Add documentation for the Gravitino-Trino connector running on AWS S3. #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Aug 28, 2024
yuqi1129
reviewed
Aug 29, 2024
FANNG1
reviewed
Aug 30, 2024
FANNG1
reviewed
Aug 30, 2024
| 'lakehouse-iceberg', | ||
| map( | ||
| array['uri', 'catalog-backend', 'warehouse', | ||
| 'trino.bypass.hive.s3.aws-access-key', 'trino.bypass.hive.s3.aws-secret-key', 'trino.bypass.hive.s3.region', |
There was a problem hiding this comment.
That's ok. If we use original s3, we don't need it
FANNG1
reviewed
Aug 30, 2024
| 'lakehouse-iceberg', | ||
| map( | ||
| array['uri', 'catalog-backend', 'warehouse', | ||
| 'trino.bypass.hive.s3.aws-access-key', 'trino.bypass.hive.s3.aws-secret-key', 'trino.bypass.hive.s3.region', |
There was a problem hiding this comment.
it's tricky to add aws-access-key and trino.bypass.hive.s3.aws-access-key, could you set the security key when do the query?
There was a problem hiding this comment.
The internal connector like Hive connector doesn't support it. I think we need to encrypt the sensitive data.
|
Generally LGTM, @FANNG1 , do you have any further comments? |
It's not proper to distribute AKSK in |
yuqi1129
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add documentation for the Gravitino-Trino connector running on AWS S3.
The Hive catalog and Iceberg catalog support S3
Why are the changes needed?
Fix: #4657
Does this PR introduce any user-facing change?
Update docs
How was this patch tested?
NO