[#4581]feat(iceberg) support Gravitino-based multi catalog support for Gravitino Iceberg REST server #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2024 20:39
…ort for Gravitino Iceberg REST server
…ort for Gravitino Iceberg REST server
|
@jerryshao @FANNG1 please help to review, Thanks. |
FANNG1
reviewed
Aug 21, 2024
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/gravitino/iceberg/common/ops/GravitinoBasedIcebergTableOpsProvider.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/gravitino/iceberg/common/ops/GravitinoBasedIcebergTableOpsProvider.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/gravitino/iceberg/common/ops/GravitinoBasedIcebergTableOpsProvider.java
Outdated
Show resolved
Hide resolved
added 3 commits
August 22, 2024 11:22
…ort for Gravitino Iceberg REST server
…ort for Gravitino Iceberg REST server
…ort for Gravitino Iceberg REST server
|
@FANNG1 All comments have been resolved. Could you review it again? Thanks |
FANNG1
reviewed
Aug 23, 2024
...g-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergTableOpsManager.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Aug 23, 2024
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java
Show resolved
Hide resolved
FANNG1
reviewed
Aug 23, 2024
...c/main/java/org/apache/gravitino/iceberg/provider/GravitinoBasedIcebergTableOpsProvider.java
Outdated
Show resolved
Hide resolved
|
LGTM except minor comments |
added 2 commits
August 23, 2024 12:41
…ort for Gravitino Iceberg REST server
…ort for Gravitino Iceberg REST server
FANNG1
reviewed
Aug 23, 2024
FANNG1
reviewed
Aug 23, 2024
…ort for Gravitino Iceberg REST server
FANNG1
reviewed
Aug 23, 2024
...g-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergTableOpsManager.java
Outdated
Show resolved
Hide resolved
…ort for Gravitino Iceberg REST server
FANNG1
reviewed
Aug 23, 2024
...c/main/java/org/apache/gravitino/iceberg/provider/GravitinoBasedIcebergTableOpsProvider.java
Outdated
Show resolved
Hide resolved
…ort for Gravitino Iceberg REST server
FANNG1
reviewed
Aug 23, 2024
...g-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergTableOpsManager.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Aug 23, 2024
…ort for Gravitino Iceberg REST server
FANNG1
approved these changes
Aug 25, 2024
|
@theoryxu , thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support Gravitino-based multi catalog support for Gravitino Iceberg REST server
Why are the changes needed?
fixes: #4581
Does this PR introduce any user-facing change?
add a property key
How was this patch tested?