-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4072] improvement(docker-image): Transfer docker hub from datastrato to apache #4523
Changes from 26 commits
8160b7f
730d016
4a27da0
330d059
ef87a09
f571c6d
846d9cc
32e9509
63af7d4
6adfa3b
f715e60
d63c68d
d7c926f
5375762
54a5a02
cc288c8
9b242e2
6a31c1f
4aa1a57
fd15a61
415df73
41d2a35
719024b
5dd87bc
6395896
53d72bb
28de08a
0cbcba4
acd3da5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,7 @@ RUN mkdir /tmp/gravitino | |
COPY --chown=trino:trino packages/gravitino-trino-connector /tmp/gravitino | ||
|
||
ARG IMAGE_NAME | ||
RUN if [ "$IMAGE_NAME" = "datastrato/trino" ] ; then \ | ||
RUN if [ "$IMAGE_NAME" = "apache/gravitino-*:trino-*" ] ; then \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @diqiu50 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I this this is better:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After this PR, the name for Trino Docker image will be: apache/gravitino-ci:trino-xxxx There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @diqiu50 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's ok. |
||
mv /tmp/gravitino /usr/lib/trino/plugin/; \ | ||
else echo "Copying files for other images"; \ | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the display name in GitHub image actions, I've already updated the final image name. Please refer to line 84.