[#436] fix(catalog-lakehouse): create dummy reportMetrics interface to remove warning message when spark writing data using IcebergRestCatalog #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
Clearvive
approved these changes
Sep 26, 2023
| @PathParam("namespace") String namespace, | ||
| @PathParam("table") String table, | ||
| ReportMetricsRequest request) { | ||
| return IcebergRestUtils.noContent(); |
There was a problem hiding this comment.
Is this a plan to implement it in the future, and should TODO be added?
There was a problem hiding this comment.
@sandflee please reply this comment, thanks.
There was a problem hiding this comment.
yes， this PR just add a mock interface to remove the spark warning message， How to store and retrieve the metrics may be an attractive feature， needs a detailed design。
jerryshao
changed the title
Clearvive
pushed a commit
that referenced
this pull request
Oct 17, 2023
…o remove warning message when spark writing data using IcebergRestCatalog (#449) ### What changes were proposed in this pull request? add `reportMetrics` interfaces ### Why are the changes needed? remove warning message when spark writing&reading data using IcebergRestCatalog Fix: #436 ### Does this PR introduce _any_ user-facing change? add new Iceberg REST interface ### How was this patch tested? 1. UT 2. real env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
reportMetricsinterfacesWhy are the changes needed?
remove warning message when spark writing&reading data using IcebergRestCatalog
Fix: #436
Does this PR introduce any user-facing change?
add new Iceberg REST interface
How was this patch tested?