[#4409] Improvement(JDBCBackend.java): replace switch with if statement #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mushroom528 thank a lot for your contribution. I think we deliberately chose switch..case instead of if..else here, because we will add more relation types here later on. So I think it isn't worth change. Still, thanks a lot for your contribution. |
|
all right😊 |
|
Thanks @mushroom528 for your understanding, I'm going to close this PR, you can work on other issues you're interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The switch in JDBCBackend.java (line 371) can be replaced by an if statement.
Why are the changes needed?
Improvement: #4409
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Exist testers