Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4180] fix(ui): show the required key msg when submit validate #4388

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

LauraXia123
Copy link
Collaborator

What changes were proposed in this pull request?

Show the required key msg when submit validate
image

Why are the changes needed?

N/A

Fix: #4180

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

manually operated

@jerryshao
Copy link
Contributor

Is the fix here related to issues in #4180 , I'm not so clear about it, can you please explain more?

@LauraXia123
Copy link
Collaborator Author

LauraXia123 commented Aug 6, 2024

sure, the property key is required, if you add a new property item but not input any key value, it will be failed submission by form validation.
There were no error tips for that before the fix.

@jerryshao jerryshao merged commit 2a23085 into apache:main Aug 7, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
### What changes were proposed in this pull request?

Show the required key msg when submit validate
<img width="603" alt="image"
src="https://github.com/user-attachments/assets/b3d8dca8-8b6d-43b8-aa39-203e6e32ffa1">


### Why are the changes needed?
N/A

Fix: #4180

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manually operated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] UI: Click "UPDATE" button, nothing happened if there's empty property widget on catalog edit page
2 participants