Fix potential NullPointerException in UserContext by adding null check for parentContext. #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for parentContext. Added a null check before calling deepCopy() on parentContext in the getUserContext method to prevent a possible NullPointerException. This ensures the robustness of the code when dealing with authentication contexts
mrkartik00
changed the title
justinmclean
reviewed
Aug 4, 2024
yuqi1129
reviewed
Aug 5, 2024
...log-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/UserContext.java
Outdated
Show resolved
Hide resolved
|
@mrkartik00 It looks like the comments have still been removed. Can you please add them back? |
|
Please remove the "// Improvement: Check if parentContext is not null before using it" there is no need for this comment in the code. |
yuqi1129
approved these changes
Aug 7, 2024
| @@ -125,7 +125,7 @@ public static UserContext getUserContext( | |||
| } else if (authenticationType == AuthenticationType.KERBEROS) { | |||
| // if the kerberos authentication is inherited from the parent context, we will use the | |||
| // parent context's kerberos configuration. | |||
| if (authenticationConfig.isSimpleAuth()) { | |||
| if (parentContext != null && authenticationConfig.isSimpleAuth()) { | |||
There was a problem hiding this comment.
In fact, if the value of authenticationType is KERBEROS and authenticationConfig.isSimpleAuth() is true, the value of parentContext is not null. Anyway, adding a check won't make things worse.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…k for parentContext. (#4348) Title: [#4331] fix: add null check for parentContext in UserContext ### What changes were proposed in this pull request? This pull request adds a null check for the parentContext variable in the getUserContext method of UserContext.java. This ensures that a NullPointerException is avoided when deepCopy() is called on parentContext. ### Why are the changes needed? The change is needed to prevent a potential NullPointerException if parentContext is null. Adding this check makes the code more reliable. Fix: #4331 ### Does this PR introduce _any_ user-facing change? No, this change does not introduce any user-facing changes. ### How was this patch tested? The change was reviewed to ensure that the null check effectively prevents the issue. No new tests were needed, as this is a preventive fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [#4331] fix: add null check for parentContext in UserContext
What changes were proposed in this pull request?
This pull request adds a null check for the parentContext variable in the getUserContext method of UserContext.java. This ensures that a NullPointerException is avoided when deepCopy() is called on parentContext.
Why are the changes needed?
The change is needed to prevent a potential NullPointerException if parentContext is null. Adding this check makes the code more reliable.
Fix: #4331
Does this PR introduce any user-facing change?
No, this change does not introduce any user-facing changes.
How was this patch tested?
The change was reviewed to ensure that the null check effectively prevents the issue. No new tests were needed, as this is a preventive fix.