[#366] feat(catalog-lakehouse): add IcebergRESTService #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
yuqi1129
reviewed
Sep 21, 2023
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
Clearvive
reviewed
Sep 22, 2023
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
...house/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergRESTConfig.java
Show resolved
Hide resolved
|
@jerryshao, please have a review |
jerryshao
reviewed
Sep 25, 2023
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
| return connector; | ||
| } | ||
|
|
||
| // todo, use JettyServer when it's moved to graviton common package |
There was a problem hiding this comment.
I think we can create a new module server-common to move jetty related to that module. It's not appropriate to move to common module, which will be used by client.
There was a problem hiding this comment.
Maybe we can do this refactoring work before this PR?
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Sep 25, 2023
...src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/IcebergAuxiliaryService.java
Outdated
Show resolved
Hide resolved
FANNG1
changed the title
jerryshao
reviewed
Sep 25, 2023
| .version("0.1.0") | ||
| .intConf() | ||
| .createWithDefault(100); | ||
| } |
There was a problem hiding this comment.
All these confs are from "0.2.0", we need to change them.
jerryshao
reviewed
Sep 25, 2023
|
|
||
| public class IcebergRESTService implements GravitonAuxiliaryService { | ||
|
|
||
| private Logger LOG = LoggerFactory.getLogger(IcebergRESTService.class); |
jerryshao
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add IcebergAuxiliaryService to start Iceberg REST server
Why are the changes needed?
Fix: #366
Does this PR introduce any user-facing change?
add Iceberg REST server
How was this patch tested?
pass Integration test