-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4181]Improvement: Support setting gradle property skipDockerTests by environment variant #4229
Conversation
Can you please add some description in the doc gravitino/docs/how-to-build.md Lines 28 to 30 in 80e1fc7
|
Sure, I have updated the doc. |
LTGM |
@yuqi1129 @mchades @featherchen Do we need to keep |
If we do not add it in the |
build.gradle.kts
Outdated
val skipDockerTest = if (extra["skipDockerTests"].toString().toBoolean()) { | ||
System.getenv("SKIP_DOCKER_TESTS")?.toBoolean() ?: true | ||
} else { | ||
false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments to clarify the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have add some comments, hope it could help to make the logic clearer.
Furthermore, if we do not add it, we still need to give the default value of it in related parts of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changes were proposed in this pull request?
Read the environment variable (if exists) when -PskipDockerTests is not specified.
Why are the changes needed?
Fix: #4181
Does this PR introduce any user-facing change?
No
How was this patch tested?