Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4059] feat(iceberg-rest-server): support Iceberg REST server docker image #4138

Merged
merged 7 commits into from
Aug 1, 2024
Merged

[#4059] feat(iceberg-rest-server): support Iceberg REST server docker image #4138

merged 7 commits into from
Aug 1, 2024

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Jul 11, 2024 •
edited
Loading

What changes were proposed in this pull request?

add gravitino iceberg rest service docker image

Why are the changes needed?

  1. setup Gravition Iceberg REST service easily for test
  2. user could add customer changes and setup a new docker image for product.

Fix: #4059

Does this PR introduce any user-facing change?

no

How was this patch tested?

in local machine, setup docker image and check it works

@FANNG1 FANNG1 changed the title Iceberg docker [SIP] Iceberg docker Jul 11, 2024
@FANNG1 FANNG1 marked this pull request as draft July 11, 2024 07:17
@FANNG1 FANNG1 changed the title [SIP] Iceberg docker [SIP] support Iceberg REST server docker image Jul 11, 2024
@FANNG1 FANNG1 changed the title [SIP] support Iceberg REST server docker image [#4059] feat(iceberg-rest-server): support Iceberg REST server docker image Jul 24, 2024
@FANNG1 FANNG1 marked this pull request as ready for review July 24, 2024 03:52
@FANNG1 FANNG1 requested review from jerryshao and yuqi1129 July 24, 2024 03:53
@yuqi1129
Copy link
Contributor

Besides, please add document for it in the file docker-image-details.md

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jul 24, 2024

Besides, please add document for it in the file docker-image-details.md

added

yuqi1129
yuqi1129 reviewed Jul 24, 2024
View reviewed changes
docs/docker-image-details.md Show resolved Hide resolved
docs/docker-image-details.md Outdated Show resolved Hide resolved
@yuqi1129
Copy link
Contributor

@mchades
Would you like to take a look?

@FANNG1 FANNG1 requested review from yuqi1129 and jerqi July 31, 2024 08:35
@jerryshao jerryshao requested review from mchades and removed request for jerqi July 31, 2024 09:27
mchades
mchades approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Remember to add a new tag after merging. @FANNG1

@mchades mchades merged commit b5308ca into apache:main Aug 1, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi left review comments

@mchades mchades mchades approved these changes

@jerryshao jerryshao Awaiting requested review from jerryshao

@yuqi1129 yuqi1129 Awaiting requested review from yuqi1129

Assignees

@FANNG1 FANNG1

Labels
ICEBERG-REST-SERVER
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] provide separate docker image for Iceberg REST Server
5 participants
@FANNG1 @yuqi1129 @jerryshao @jerqi @mchades