[#4062] feat(iceberg-rest-server): support RegisterTable for Iceberg REST server #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
force-pushed
the
register1
branch
7 times, most recently
from
45adcf0 to
14eb09a
Compare
FANNG1
force-pushed
the
register1
branch
3 times, most recently
from
8e81f3b to
0005f70
Compare
FANNG1
commented
Jul 23, 2024
| @@ -60,7 +60,7 @@ void testLoadCatalog() { | |||
| }); | |||
|
|
|||
| Map<String, String> properties = new HashMap<>(); | |||
| properties.put(CatalogProperties.URI, "jdbc://0.0.0.0:3306"); | |||
There was a problem hiding this comment.
the new Iceberg version will check the correctness of jdbc uri
FANNG1
commented
Jul 23, 2024
| @@ -107,10 +108,10 @@ private Response doLoadTable(String name) { | |||
| } | |||
|
|
|||
| private Response doUpdateTable(String name, TableMetadata base) { | |||
| MetadataUpdate addSchema = new AddSchema(newTableSchema, base.lastColumnId()); | |||
There was a problem hiding this comment.
API changes for new Iceberg Version
FANNG1
changed the title
FANNG1
changed the title
|
@jerryshao please help to review when you have time |
jerryshao
reviewed
Jul 24, 2024
| convertToStringList( | ||
| sql( | ||
| String.format( | ||
| "select file from %s.%s.metadata_log_entries", registerDB, registerTableName)), |
There was a problem hiding this comment.
Can you please make all the SQL keywords uppercase.
jerryshao
reviewed
Jul 24, 2024
| Assertions.assertEquals(ImmutableMap.of("1", "a"), result); | ||
|
|
||
| // insert other data | ||
| sql(" INSERT INTO iceberg_rest_table_test.register_foo2 VALUES (2, 'b')"); |
There was a problem hiding this comment.
Remove the whitespace before "INSERT".
|
@jerryshao @jerqi , comments are addressed, could you help to review again? |
jerryshao
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #4062
Does this PR introduce any user-facing change?
no
How was this patch tested?