-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#321] feat(core): add auxiliary service support in Graviton #406
Conversation
Code Coverage Report
Files
|
Hi @sandflee
|
@sandflee Do you rebase your develop branch to the latest main branch?
|
Can you provide a more detailed description of this PR? |
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxService.java
Outdated
Show resolved
Hide resolved
We do not have privileges to access this document. |
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
…ce && add exception to serviceStop for aux service
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/GravitonAuxiliaryService.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/aux/AuxiliaryServiceManager.java
Outdated
Show resolved
Hide resolved
|
||
String gravitonHome = System.getenv("GRAVITON_HOME"); | ||
if (!path.isAbsolute() && gravitonHome != null) { | ||
Path newPath = Paths.get(gravitonHome, pathString); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you configure the "classpath" config, is it a relative path or a absolute path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it supports both relative path and absolute path, if it's a relative path, it relative to gravitonHome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tested in MiniGraviton, catalogs jars is placed in catalog-xx/build/libs/
, will try to get aux test classpath in auxServiceTestClassPaths
if in test mode
// in product mode, catalogs jars is placed in catalogs/xx/libs/ | ||
private static final Map<String, String> auxServiceTestClassPaths = | ||
ImmutableMap.of( | ||
"GravitonIcebergREST", Paths.get("catalog-lakehouse", "build", "libs").toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can inject the configuration when running mini graviton mode, I don't think it is a good idea to hardcode here.
What changes were proposed in this pull request?
add a aux service to graviton to support Iceberg REST server
Why are the changes needed?
support Iceberg REST server
part: #321
will propose another PR to start Iceberg REST server.
Does this PR introduce any user-facing change?
add Iceberg REST server
How was this patch tested?
design docs
https://docs.google.com/document/d/1N_9NtaoHIeKQ36Q4fYZ9eGDotvjlB0-7lHKSoT76IZk/edit#heading=h.kbhoexq6d6ba