Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4031] build: Add the asf yaml for Gravitino #4033

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

jerqi
Copy link
Contributor

@jerqi jerqi commented Jul 3, 2024

What changes were proposed in this pull request?

Add the asf yaml for Gravitino

Why are the changes needed?

Fix: #4031

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This pull request needs to be verified after mering.

.asf.yaml Outdated

github:
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
homepage: https://datastrato.ai/docs/0.5.1/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced when we have the new website.

.asf.yaml Outdated

github:
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
homepage: https://datastrato.ai/docs/0.5.1/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suffix 0.5.1 is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.asf.yaml Outdated
- opendatacatalog
features:
# Enable wiki for documentation
wiki: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to enable wiki, we will use website for documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to false.

.asf.yaml Outdated
enabled_merge_buttons:
squash: true
merge: false
rebase: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better enable rebase for some scenarios like merging big features from dev branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to true.

strict: true
required_pull_request_reviews:
dismiss_stale_reviews: true
required_approving_review_count: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add branch-* to the protected branches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added.

Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

#

github:
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description may also need be updated after joing incubator. Using "Leading" or something else to replace "most powerful".

@jerryshao jerryshao merged commit 0e59cc8 into apache:main Jul 3, 2024
13 checks passed
jerryshao pushed a commit that referenced this pull request Jul 3, 2024
### What changes were proposed in this pull request?
Apache infra doesn't support `branch-*`.

### Why are the changes needed?

This is a follow-up pull request of #4033 

Fix: #4031 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

Verified after merging.
@jerqi jerqi deleted the ISSUE-4031 branch July 3, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add the asf yaml for Gravitino
4 participants