-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4031] build: Add the asf yaml for Gravitino #4033
Conversation
.asf.yaml
Outdated
|
||
github: | ||
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake. | ||
homepage: https://datastrato.ai/docs/0.5.1/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be replaced when we have the new website.
.asf.yaml
Outdated
|
||
github: | ||
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake. | ||
homepage: https://datastrato.ai/docs/0.5.1/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suffix 0.5.1 is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
.asf.yaml
Outdated
- opendatacatalog | ||
features: | ||
# Enable wiki for documentation | ||
wiki: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to enable wiki, we will use website for documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to false.
.asf.yaml
Outdated
enabled_merge_buttons: | ||
squash: true | ||
merge: false | ||
rebase: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better enable rebase
for some scenarios like merging big features from dev branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to true.
strict: true | ||
required_pull_request_reviews: | ||
dismiss_stale_reviews: true | ||
required_approving_review_count: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add branch-*
to the protected branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
# | ||
|
||
github: | ||
description: World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description may also need be updated after joing incubator. Using "Leading" or something else to replace "most powerful".
What changes were proposed in this pull request?
Add the asf yaml for Gravitino
Why are the changes needed?
Fix: #4031
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This pull request needs to be verified after mering.