Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4065] improvement(test): Fix the path of integration log is wrong. #4029

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Jul 2, 2024

What changes were proposed in this pull request?

  • Fix the path of the integration test is not as expected.
  • Remove directory data that lies in root project.

Why are the changes needed?

The path is not right.

Fixed: #4065

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Test locally.

Before

image

After

image

@yuqi1129 yuqi1129 closed this Jul 2, 2024
@yuqi1129 yuqi1129 reopened this Jul 2, 2024
@zhoukangcn
Copy link
Contributor

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build
which is used in build.yml

image

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 3, 2024

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml

image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

@zhoukangcn
Copy link
Contributor

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml
image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 3, 2024

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml
image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

Let me check it.

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 3, 2024

@yuqi1129 still have this problem with command ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false -x :clients:client-python:build which is used in build.yml
image

Do you reproduce it in this branch (yuqi1129:minor) or the main branch?

on branch yuqi1129:minor

Let me check it.

It seems that the system property in the log configuration file does not work

image

@yuqi1129 yuqi1129 changed the title [Minor] improvement(test): Fix the path of integration log is wrong. [#4065] improvement(test): Fix the path of integration log is wrong. Jul 4, 2024
@yuqi1129 yuqi1129 closed this Jul 4, 2024
@yuqi1129 yuqi1129 reopened this Jul 4, 2024
@yuqi1129 yuqi1129 self-assigned this Jul 4, 2024
@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 8, 2024

@zhoukangcn
Could you help to review it again?

@zhoukangcn
Copy link
Contributor

@zhoukangcn Could you help to review it again?

OK,I will check it later

@zhoukangcn zhoukangcn added the upload log Always upload container log label Jul 9, 2024
@zhoukangcn
Copy link
Contributor

image @yuqi1129 Does this meet the expectations?

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 9, 2024

image @yuqi1129 Does this meet the expectations?

@zhoukangcn I think so, @diqiu50 . Can you help to confirm it?

@zhoukangcn
Copy link
Contributor

Others LGTM

@zhoukangcn zhoukangcn self-requested a review July 9, 2024 08:37
@diqiu50
Copy link
Contributor

diqiu50 commented Jul 9, 2024

image @yuqi1129 Does this meet the expectations?

@zhoukangcn I think so, @diqiu50 . Can you help to confirm it?

That's fine. It's the Trino container logs

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 9, 2024

It's the Trino container logs

OK

@yuqi1129 yuqi1129 merged commit 7c8fc04 into apache:main Jul 9, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upload log Always upload container log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] The path of integration test is incorrect
3 participants