[#3968] improvement(core): Disable KV entity store and optimize CI #3975
Conversation
...adoop/src/test/java/com/datastrato/gravitino/catalog/hadoop/TestHadoopCatalogOperations.java
Outdated
Show resolved
Hide resolved
| @@ -61,7 +61,7 @@ jobs: | |||
| architecture: [linux/amd64] | |||
| java-version: [ 8, 11, 17 ] | |||
| test-mode: [ embedded, deploy ] | |||
| backend: [ jdbcBackend, kvBackend] | |||
| backend: [ mysql, h2] | |||
There was a problem hiding this comment.
I think maybe we can reduce the pipeline to combine embedded with h2, and deploy with msyql, WDYT?
There was a problem hiding this comment.
In general, test-mode and backend are different things, I would rather to remove embedded mode in the test-mode to reduce pipelines as backend h2 and MySQL will be run by the user in the real environment, however embedded mode will never exists in real environment.
...adoop/src/test/java/com/datastrato/gravitino/catalog/hadoop/TestHadoopCatalogOperations.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/EntityStoreFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/datastrato/gravitino/storage/kv/TestEntityKeyEncoding.java
Outdated
Show resolved
Hide resolved
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
| import org.mockito.Mockito; | ||
|
|
||
| @Disabled |
gradle.properties
Outdated
| @@ -41,3 +41,5 @@ pythonVersion = 3.8 | |||
|
|
|||
| # skipDockerTests is used to skip the tests that require Docker to be running. | |||
| skipDockerTests = true | |||
| # The default backend for the JDBC tests, you set it to h2 or mysql | |||
| jdbcBackend = h2 | |||
There was a problem hiding this comment.
I think we should figure out a better way for test between h2 and MySQL.
- For UT, we can use H2.
- For IT, we'd better run both.
So, we don't have to make a configuration there, WDYT?
There was a problem hiding this comment.
OK, Add the configuration here is indeed unnecessary as H2 is the default one.
For UT, we can use H2.
For IT, we'd better run both.
Yeah, the strategy is correct. I will check it again.
|
Did you update the docs about the change to use H2 by default? |
The document are not fully changed, I will refine it. |
What changes were proposed in this pull request?
jdbcBackendWhy are the changes needed?
We are going to deprecate kv entity store
Fix: #3968
Why are the changes needed?
N/A
How was this patch tested?
Existing test.