[#3906] improvement(hive-catalog): Add user authentication IT for multiple HMS #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/integration/test/MultipleHMSUserAuthenticationIT.java
yuqi1129
changed the title
|
@mchades |
mchades
reviewed
Jul 31, 2024
| String ip = kerberosHiveContainer.getContainerIpAddress(); | ||
| int port = HiveContainer.HIVE_METASTORE_PORT; | ||
| // Multiple HMS URIs, I put the new one first to test the new HMS URI first. | ||
| HIVE_METASTORE_URI = String.format("thrift://%s:1%d,thrift://%s:%d", ip, port, ip, port); |
There was a problem hiding this comment.
please use a new port parameter, 1%d looks too tricky
|
@mchades |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add IT about user authentication for Hive catalog with Kerberos enabled.
Why are the changes needed?
To cover more usage cases.
Fix: #3906
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
N/A