-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3368] feat(jdbc-doris): support pre-assign partition for Doris table #3887
Conversation
89c73aa
to
a309f13
Compare
@mchades @zhoukangcn , would you help review this when you are free? |
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Outdated
Show resolved
Hide resolved
6256fdd
to
ee2c22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review.
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/datastrato/gravitino/catalog/doris/operation/TestDorisTableOperations.java
Outdated
Show resolved
Hide resolved
# Conflicts: # catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java # catalogs/catalog-jdbc-doris/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java # catalogs/catalog-jdbc-doris/src/test/java/org/apache/gravitino/catalog/doris/operation/TestDorisTableOperations.java
@mchades, this PR is ready for review, thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. @yuqi1129 Do you want to take another look?
I'm okay with the current changes. |
What changes were proposed in this pull request?
Support pre-assign partition for Doris table.
Why are the changes needed?
Fix: #3368
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT & IT