Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3368] feat(jdbc-doris): support pre-assign partition for Doris table #3887

Merged
merged 16 commits into from
Jul 30, 2024

Conversation

xiaozcy
Copy link
Contributor

@xiaozcy xiaozcy commented Jun 18, 2024

What changes were proposed in this pull request?

Support pre-assign partition for Doris table.

Why are the changes needed?

Fix: #3368

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT & IT

@xiaozcy xiaozcy force-pushed the doris-pre-assign-partition branch 2 times, most recently from 89c73aa to a309f13 Compare June 18, 2024 12:13
@xiaozcy xiaozcy closed this Jun 18, 2024
@xiaozcy xiaozcy reopened this Jun 18, 2024
@xiaozcy xiaozcy marked this pull request as ready for review June 18, 2024 13:19
@xiaozcy
Copy link
Contributor Author

xiaozcy commented Jun 18, 2024

@mchades @zhoukangcn , would you help review this when you are free?

@mchades mchades self-requested a review June 19, 2024 03:37
@xiaozcy xiaozcy force-pushed the doris-pre-assign-partition branch from 6256fdd to ee2c22a Compare June 19, 2024 08:47
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review.

@xiaozcy xiaozcy marked this pull request as draft July 1, 2024 09:36
zhanghan18 added 2 commits July 24, 2024 16:02
# Conflicts:
#	catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
#	catalogs/catalog-jdbc-doris/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java
#	catalogs/catalog-jdbc-doris/src/test/java/org/apache/gravitino/catalog/doris/operation/TestDorisTableOperations.java
@xiaozcy xiaozcy marked this pull request as ready for review July 25, 2024 07:24
@xiaozcy
Copy link
Contributor Author

xiaozcy commented Jul 25, 2024

@mchades, this PR is ready for review, thx.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. @yuqi1129 Do you want to take another look?

@yuqi1129
Copy link
Contributor

Overall LGTM. @yuqi1129 Do you want to take another look?

I'm okay with the current changes.

@mchades mchades merged commit 4acdc49 into apache:main Jul 30, 2024
33 checks passed
@jerryshao jerryshao added 0.6.0 and removed 0.6.0 labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] enable pre-assign partition for Doris catalog
4 participants