[#3371] feat(flink-connector): support basic table operation #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FANNG1 Please help review this PR when you have time. Thanks. |
|
@coolderli , table operation is complicated, do you mind to split it to smaller PRs, like
|
coolderli
changed the title
|
@FANNG1 Please help review this. Thanks. |
FANNG1
reviewed
Jul 3, 2024
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/catalog/BaseCatalog.java
Show resolved
Hide resolved
flink-connector/src/main/java/com/datastrato/gravitino/flink/connector/utils/TypeUtils.java
Show resolved
Hide resolved
| @@ -258,6 +278,154 @@ public void testGetCatalogFromGravitino() { | |||
| numCatalogs, tableEnv.listCatalogs().length, "The created catalog should be dropped."); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCreateNoPartitionTable() { | |||
There was a problem hiding this comment.
could you add write&read data after creating table?
.../java/com/datastrato/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java
Outdated
Show resolved
Hide resolved
|
@FANNG1 I have finished it. Please take a review. Thanks. |
|
@FANNG1 I have fixed the license problem. Please help approve the pipeline and review it again. Thanks. |
FANNG1
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?