[#3092] fix(relational-entity-store): Return false when deleting throw a NoSuchEntityException
#3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w a `NoSuchEntityException` (#3100) ### What changes were proposed in this pull request? When Relational Entity Store deleteing an entity and throwing a NoSuchEntityException, return false finally. It's consistent with KV Store. ### Why are the changes needed? Fix: #3092 ### How was this patch tested? Add some duplicate deleted uts. --------- Co-authored-by: xiaojiebao <[email protected]>
jerryshao
added
cherry-pick
need backport
yuqi1129
approved these changes
May 9, 2024
yuqi1129
deleted the
cherry-pick-branch-0.5-c740b13f3ee907ce72dbf2d52247ee0fa826ba27
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Relational Entity Store deleteing an entity and throwing a NoSuchEntityException, return false finally. It's consistent with KV Store.
Why are the changes needed?
Fix: #3092
How was this patch tested?
Add some duplicate deleted uts.