[#3187] feat(spark-connector): Support SparkSQL extended syntax in Iceberg #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caican00
force-pushed
the
iceberg-extended-sql
branch
2 times, most recently
from
49baf5c to
8cba728
Compare
caican00
force-pushed
the
iceberg-extended-sql
branch
from
8cba728 to
0826647
Compare
caican00
force-pushed
the
iceberg-extended-sql
branch
from
0826647 to
0a8ff35
Compare
…berg-extended-sql
caican00
force-pushed
the
iceberg-extended-sql
branch
from
f5ea86a to
b97c325
Compare
caican00
commented
May 21, 2024
...strato/gravitino/spark/connector/iceberg/extensions/IcebergExtendedDataSourceV2Strategy.java
Outdated
Show resolved
Hide resolved
|
Hi @FANNG1 could you help re-trigger the pipeline because doris container startup failed |
done |
|
@FANNG1 ready for review, could you help review it when you are free? thanks! |
FANNG1
reviewed
Jun 6, 2024
...strato/gravitino/spark/connector/iceberg/extensions/IcebergExtendedDataSourceV2Strategy.java
Show resolved
Hide resolved
FANNG1
reviewed
Jun 6, 2024
...strato/gravitino/spark/connector/iceberg/extensions/IcebergExtendedDataSourceV2Strategy.java
Show resolved
Hide resolved
|
@jerryshao @qqqttt123 do you have time to review this PR? |
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jun 7, 2024
...com/datastrato/gravitino/spark/connector/integration/test/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
caican00
force-pushed
the
iceberg-extended-sql
branch
from
b05720a to
71fb559
Compare
|
Hi @FANNG1 could you help review this again? thank you! |
FANNG1
reviewed
Jun 13, 2024
...mon/src/main/java/com/datastrato/gravitino/spark/connector/plugin/GravitinoDriverPlugin.java
Outdated
Show resolved
Hide resolved
|
LGTM, except one comment |
comment has been addressed. cc @FANNG1 |
FANNG1
reviewed
Jun 13, 2024
...mon/src/main/java/com/datastrato/gravitino/spark/connector/plugin/GravitinoDriverPlugin.java
Show resolved
Hide resolved
|
LGTM |
FANNG1
approved these changes
Jun 14, 2024
|
@caican00 merged to the main, thanks for your work |
shaofengshi
pushed a commit
to shaofengshi/gravitino
that referenced
this pull request
Jun 24, 2024
… in Iceberg (apache#3266) ### What changes were proposed in this pull request? Support SparkSQL extended syntax in Iceberg, such as: ``` addPartitionField dropPartitionField replacePartitionField setWriteDistributionAndOrdering setIdentifierFields dropIdentifierFields createOrReplaceBranch createOrReplaceTag dropBranch dropTag ``` ### Why are the changes needed? Support SparkSQL extended syntax in Iceberg. Fix: apache#3187 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support SparkSQL extended syntax in Iceberg, such as:
Why are the changes needed?
Support SparkSQL extended syntax in Iceberg.
Fix: #3187
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New ITs.