-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3264] feat(spark-connector): Support Iceberg time travel in SQL queries #3265
Conversation
Finally, I still choose to implement Iceberg
In this case, users specify the version for time travel, but the version may be snapshotId or branch name.
|
cc @FANNG1 |
How about Override |
in this way, we still have the problem of initializing the |
Let me think a while |
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/hive/SparkHiveTable.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/datastrato/gravitino/spark/connector/iceberg/GravitinoIcebergCatalog.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
...nector/src/main/java/com/datastrato/gravitino/spark/connector/iceberg/SparkIcebergTable.java
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Show resolved
Hide resolved
fixed conflict, and could you please help review again if you are free? Thank you @FANNG1 |
.../src/main/java/com/datastrato/gravitino/spark/connector/iceberg/GravitinoIcebergCatalog.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
LGTM, except minor comments |
comments have been addressed, and could you please help review again? @FANNG1 |
…ries (#3265) ### What changes were proposed in this pull request? Support Iceberg time travel in SQL queries ### Why are the changes needed? supports time travel in SQL queries using `TIMESTAMP AS OF`, `FOR SYSTEM_TIME AS OF` or `VERSION AS OF`, `FOR SYSTEM_VERSION AS OF` clauses. Fix: #3264 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New ITs.
@caican00 , thanks for your contribution! |
…QL queries (apache#3265) ### What changes were proposed in this pull request? Support Iceberg time travel in SQL queries ### Why are the changes needed? supports time travel in SQL queries using `TIMESTAMP AS OF`, `FOR SYSTEM_TIME AS OF` or `VERSION AS OF`, `FOR SYSTEM_VERSION AS OF` clauses. Fix: apache#3264 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New ITs.
What changes were proposed in this pull request?
Support Iceberg time travel in SQL queries
Why are the changes needed?
supports time travel in SQL queries using
TIMESTAMP AS OF
,FOR SYSTEM_TIME AS OF
orVERSION AS OF
,FOR SYSTEM_VERSION AS OF
clauses.Fix: #3264
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New ITs.