Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3237] fix(IT): use simple catalog name in TrinoContainer #3238

Merged
merged 2 commits into from
May 1, 2024

Conversation

xiaozcy
Copy link
Contributor

@xiaozcy xiaozcy commented Apr 30, 2024

What changes were proposed in this pull request?

use simple catalog name in com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino, and verify it where it is called.

Why are the changes needed?

Fix: #3237

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

ITs

@xiaozcy xiaozcy changed the title fix(IT): use simple catalog name in TrinoContainer [#3237] fix(IT): use simple catalog name in TrinoContainer Apr 30, 2024
@yuqi1129 yuqi1129 added branch-0.5 need backport Issues that need to backport to another branch labels May 1, 2024
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit a4733a4 into apache:main May 1, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2024
### What changes were proposed in this pull request?

use simple catalog name in
`com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino`,
and verify it where it is called.

### Why are the changes needed?

Fix: #3237 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…pache#3238)

### What changes were proposed in this pull request?

use simple catalog name in
`com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino`,
and verify it where it is called.

### Why are the changes needed?

Fix: apache#3237 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

ITs

---------

Co-authored-by: zhanghan18 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] TrinoContainer#checkSyncCatalogFromGravitino will always return false
2 participants