[#2434] Improvement: if DropXXX success, return true, if not exists return false #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mchades would you please help to review this? |
mchades
reviewed
May 6, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/DatabaseOperation.java
Show resolved
Hide resolved
...dbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/TableOperation.java
Show resolved
Hide resolved
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
...g-jdbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/JdbcCatalogOperations.java
Show resolved
Hide resolved
|
Are the changes in |
Yes. |
|
Update. Please help to review again when you have time~ |
mchades
reviewed
May 7, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java
Outdated
Show resolved
Hide resolved
|
Updated. Please help to review again when you have time, thanks! |
|
@mchades Updated. Please help to review again when you have time, thanks! |
mchades
reviewed
May 10, 2024
.../src/main/java/com/datastrato/gravitino/catalog/doris/converter/DorisExceptionConverter.java
Show resolved
Hide resolved
mchades
reviewed
May 10, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Outdated
Show resolved
Hide resolved
|
@charliecheng630 would you please rebase the code? |
jerryshao
reviewed
May 10, 2024
api/src/main/java/com/datastrato/gravitino/SupportsMetalakes.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
May 10, 2024
server/src/test/java/com/datastrato/gravitino/server/web/rest/TestMetalakeOperations.java
Show resolved
Hide resolved
|
@charliecheng630 can you please also confirm that if anything should be changed in the client side? |
zhoukangcn
reviewed
May 10, 2024
.../src/main/java/com/datastrato/gravitino/catalog/doris/converter/DorisExceptionConverter.java
Outdated
Show resolved
Hide resolved
...ql/src/test/java/com/datastrato/gravitino/catalog/mysql/integration/test/CatalogMysqlIT.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
May 14, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Outdated
Show resolved
Hide resolved
charliecheng630
force-pushed
the
#2434
branch
3 times, most recently
from
5daefec to
549860c
Compare
|
@mchades Rebased & updated. Please help to review again when you have time, thanks! |
mchades
reviewed
May 22, 2024
...g-jdbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/JdbcCatalogOperations.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/datastrato/gravitino/catalog/doris/converter/DorisExceptionConverter.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/JDBCBackend.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
May 29, 2024
...is/src/test/java/com/datastrato/gravitino/catalog/doris/integration/test/CatalogDorisIT.java
Outdated
Show resolved
Hide resolved
mchades
approved these changes
May 30, 2024
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…ists return false (apache#3222) ### What changes were proposed in this pull request? When dropping the XXX(Metalake/Catalog/Schema/Table/Fileset/Partition/Topic), if the XXX does not exist, then return false. ### Why are the changes needed? a clear drop behavior of return value and exception thrown. Fix: apache#2434 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ITs and UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When dropping the XXX(Metalake/Catalog/Schema/Table/Fileset/Partition/Topic), if the XXX does not exist, then return false.
Why are the changes needed?
a clear drop behavior of return value and exception thrown.
Fix: #2434
Does this PR introduce any user-facing change?
No
How was this patch tested?
ITs and UTs