[#3216] fix(core): Fix the issue of method checkValue in the ConfigOption
#3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqqttt123
added
need backport
qqqttt123
changed the title
checkValue in the ConfigOption
qqqttt123
force-pushed
the
ISSUE-3216
branch
3 times, most recently
from
22d537e to
f8ffd73
Compare
jerryshao
reviewed
Apr 29, 2024
| ConfigEntry<List<T>> conf = | ||
| new ConfigEntry<>(key, version, doc, alternatives, isPublic, isDeprecated); | ||
| conf.setValueConverter((String str) -> strToSeq(str, valueConverter)); | ||
| conf.setStringConverter((List<T> val) -> seqToStr(val, stringConverter)); | ||
| conf.setStringConverter((List<T> val) -> val == null ? "null" : seqToStr(val, stringConverter)); |
There was a problem hiding this comment.
I think it is a little weird to use "null" for null config value, can we use null directly?
jerryshao
reviewed
Apr 29, 2024
| .checkValue( | ||
| valueList -> | ||
| valueList != null && valueList.stream().allMatch(StringUtils::isNotBlank), | ||
| ConfigConstants.NOT_BLANK_ERROR_MSG) |
There was a problem hiding this comment.
Why the ordering matters? I think it is not just simply changing the ordering to fix the issue. We can misuse it if the implementation is strongly relying on the ordering, right?
There was a problem hiding this comment.
I modify the implement to fix the issue.
- If we call this method before
toSequence, it will check every element. - If we call this method after
toSequeue, it will check the list.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…Option (#3217) ### What changes were proposed in this pull request? Fix the issue of method `checkValue` in the ConfigOption. If we use `checkValue` in the wrong position, it won't work. ### Why are the changes needed? Fix: #3216 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Co-authored-by: Heng Qin <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…ConfigOption (apache#3217) ### What changes were proposed in this pull request? Fix the issue of method `checkValue` in the ConfigOption. If we use `checkValue` in the wrong position, it won't work. ### Why are the changes needed? Fix: apache#3216 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Co-authored-by: Heng Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the issue of method
checkValuein the ConfigOption. If we usecheckValuein the wrong position, it won't work.Why are the changes needed?
Fix: #3216
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.