[#3024] improvement(IT): close containers and upload container log after all tests are finished #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 28, 2024 21:00
…tests are finished
…tests are finished
zhoukangcn
reviewed
Apr 28, 2024
...on/src/test/java/com/datastrato/gravitino/integration/test/util/CloseContainerExtension.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 This PR is ready for review. BTW, can you add |
qqqttt123
pushed a commit
that referenced
this pull request
Apr 29, 2024
…ntegration-test-common` (#3201) ### What changes were proposed in this pull request? Trigger integration test when there is a change in module `integration-test-common`. ### Why are the changes needed? We should start the integration test if there are changes in module `integration-test-common`. however, CI https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197 of PR #3197 can't start the CI pipeline. Fixed: #3207 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? CI passed.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
…ntegration-test-common` (#3201) ### What changes were proposed in this pull request? Trigger integration test when there is a change in module `integration-test-common`. ### Why are the changes needed? We should start the integration test if there are changes in module `integration-test-common`. however, CI https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197 of PR #3197 can't start the CI pipeline. Fixed: #3207 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? CI passed.
qqqttt123
pushed a commit
that referenced
this pull request
Apr 29, 2024
…ntegration-test-common` (#3208) ### What changes were proposed in this pull request? Trigger integration test when there is a change in module `integration-test-common`. ### Why are the changes needed? We should start the integration test if there are changes in module `integration-test-common`. however, CI https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197 of PR #3197 can't start the CI pipeline. Fixed: #3207 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? CI passed. Co-authored-by: Qi Yu <[email protected]>
|
@xiaozcy |
@yuqi1129 I use #3213 to test if logs are uploaded as expected when some tests failed, the results indicate that everything is fine in this situation. |
I see, thanks for your work. |
yuqi1129
reviewed
Apr 29, 2024
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class CloseContainerExtension implements BeforeAllCallback { |
There was a problem hiding this comment.
@xiaozcy
Adding a comment about this class is preferred.
|
LGTM except for one small problem. |
yuqi1129
added
need backport
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
…ter all tests are finished (#3197) ### What changes were proposed in this pull request? close containers and upload container log after all tests are finished ### Why are the changes needed? Fix: #3024 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? existing ITs --------- Co-authored-by: zhanghan18 <[email protected]> Co-authored-by: Qi Yu <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…ule `integration-test-common` (apache#3201) ### What changes were proposed in this pull request? Trigger integration test when there is a change in module `integration-test-common`. ### Why are the changes needed? We should start the integration test if there are changes in module `integration-test-common`. however, CI https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197 of PR apache#3197 can't start the CI pipeline. Fixed: apache#3207 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? CI passed.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…log after all tests are finished (apache#3197) ### What changes were proposed in this pull request? close containers and upload container log after all tests are finished ### Why are the changes needed? Fix: apache#3024 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? existing ITs --------- Co-authored-by: zhanghan18 <[email protected]> Co-authored-by: Qi Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
close containers and upload container log after all tests are finished
Why are the changes needed?
Fix: #3024
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
existing ITs