[#3190] fix(jdbc-backend): Fix the cast issue when Relational Garbage Collector cleaning fileset version info #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2024 10:06
jerryshao
changed the title
yuqi1129
added
need backport
yuqi1129
reviewed
Apr 29, 2024
|
|
||
| public class FilesetMaxVersionPO { | ||
| private Long filesetId; | ||
| private Long version; |
There was a problem hiding this comment.
So we change the data type of version from integer to Long?
There was a problem hiding this comment.
@yuqi1129 I don't think it's necessary, generally integer unsigned is enough, and now when we deserialize to Java, we use Long encapsulation by default. The problem here is that the return value type of the max() function after processing version is different in different databases. In MySQL, here the Long type is returned; And in H2, the Integer type is returned. It is enough for us to do this here.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
… Collector cleaning fileset version info (#3191) ### What changes were proposed in this pull request? When obtaining the maximum version result of fileset, pass the result into the object to solve the `ClassCastException` problem. ### Why are the changes needed? Fix: #3190 ### How was this patch tested? Add some ITs. --------- Co-authored-by: xiaojiebao <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…arbage Collector cleaning fileset version info (apache#3191) ### What changes were proposed in this pull request? When obtaining the maximum version result of fileset, pass the result into the object to solve the `ClassCastException` problem. ### Why are the changes needed? Fix: apache#3190 ### How was this patch tested? Add some ITs. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When obtaining the maximum version result of fileset, pass the result into the object to solve the
ClassCastExceptionproblem.Why are the changes needed?
Fix: #3190
How was this patch tested?
Add some ITs.