[#3132] improvement(core): Use a more elegant validation of User, Group and Role NameIdentifier #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuqi1129 @qqqttt123 could you please help to review it |
|
@qqqttt123 I was wondering if we should move |
|
Could you avoid the concept of NameIdentifier to users? User/Role/Group use some virtual catalog, schema. It's not visible to users. The api module will be exposed to users. |
got it, i will move it into |
|
Yeah, it is not good to expose the name identifier for user, group to the API. Even if we expose this, user may not know how to use it. |
qqqttt123
reviewed
Apr 24, 2024
core/src/main/java/com/datastrato/gravitino/authorization/AuthorizationUtils.java
Show resolved
Hide resolved
qqqttt123
reviewed
Apr 24, 2024
core/src/main/java/com/datastrato/gravitino/authorization/AuthorizationUtils.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Apr 24, 2024
core/src/main/java/com/datastrato/gravitino/authorization/AuthorizationUtils.java
Show resolved
Hide resolved
qqqttt123
changed the title
lw-yang
changed the title
qqqttt123
approved these changes
Apr 24, 2024
qqqttt123
added
branch-0.5
need backport
qqqttt123
changed the title
qqqttt123
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
…up and Role NameIdentifier (#3143) ### What changes were proposed in this pull request? add `checkUser`, `checkGroup`, `checkRole` in `NameIdentifier` ### Why are the changes needed? Fix: #3132 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…r, Group and Role NameIdentifier (apache#3143) ### What changes were proposed in this pull request? add `checkUser`, `checkGroup`, `checkRole` in `NameIdentifier` ### Why are the changes needed? Fix: apache#3132 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
checkUser,checkGroup,checkRoleinNameIdentifierWhy are the changes needed?
Fix: #3132
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
ut