Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2115] fix(jdbc-catalog): Can't create a table in database with the same name prefix. #3134

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Add check logic about schema name when loading table meta from driver.

Why are the changes needed?

Some drivers , such as PG drivers, contain schema name information, we need to filter it. Some drivers like MySQL don't like it, we do not need to check it.
check it.

Fix: #2115

Does this PR introduce any user-facing change?

N/A.

How was this patch tested?

Add ITs: testCreateSameTableInDifferentSchema

…same name prefix. (#2116)

### What changes were proposed in this pull request?

Add check logic about schema name when loading table meta from driver. 

### Why are the changes needed?

Some drivers , such as PG drivers, contain schema name information, we
need to filter it. Some drivers like MySQL don't like it, we do not need
to check it.
check it. 

Fix: #2115 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Add ITs: `testCreateSameTableInDifferentSchema`
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Apr 23, 2024
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit c8ddf9c into branch-0.5 Apr 23, 2024
22 checks passed
@yuqi1129 yuqi1129 deleted the cherry-pick-branch-0.5-76376b0b94e46767665a4563cd91d333236c33c7 branch April 23, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants