Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3062] fix(web): Support special character like "//" and improve the interceptors of axios #3116

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

LauraXia123
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Support special character like '//' for database name or table name and so on.
image
  1. Improvment interceptors of axois for avoide repeat request
  2. Fix some runtime errors

Why are the changes needed?

N/A

Fix: #3062

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Manual

@LauraXia123 LauraXia123 added need backport Issues that need to backport to another branch branch-0.5 labels Apr 23, 2024
@LauraXia123 LauraXia123 added this to the Gravitino 0.5.0 milestone Apr 23, 2024
@LauraXia123 LauraXia123 requested a review from ch3yne April 23, 2024 04:02
@LauraXia123 LauraXia123 self-assigned this Apr 23, 2024
@jerryshao jerryshao removed this from the Gravitino 0.5.0 milestone Apr 23, 2024
@ch3yne ch3yne changed the title [#3062]fix(web): Support special character like "//" and improvment interceptors of axois [#3062] fix(web): Support special character like "//" and improve the interceptors of axios Apr 23, 2024
Copy link
Contributor

@ch3yne ch3yne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LauraXia123 LauraXia123 added this to the Gravitino 0.5.0 milestone Apr 23, 2024
@LauraXia123 LauraXia123 merged commit f8b9458 into apache:main Apr 23, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
… interceptors of axios (#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: #3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…ve the interceptors of axios (apache#3116)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

1. Support special character like '//' for database name or table name
and so on.
<img width="852" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/9ae20ce1-3683-453a-a651-53a2277a8e25">

3. Improvment interceptors of axois for avoide repeat request
4. Fix some runtime errors

### Why are the changes needed?
N/A

Fix: apache#3062

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.5 need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Support special character like '//' for database name
3 participants