[#3051] fix(kafka-catalog): Make the catalog creation failure exception more accurate #3060
Conversation
| @@ -132,8 +134,16 @@ public void initialize(Map<String, String> config, CatalogInfo info) throws Runt | |||
| AdminClientConfig.CLIENT_ID_CONFIG, | |||
| String.format(CLIENT_ID_TEMPLATE, config.get(ID_KEY), info.namespace(), info.name())); | |||
|
|
|||
| try { | |||
| adminClient = AdminClient.create(adminClientConfig); | |||
There was a problem hiding this comment.
What's the timeout? The web page has hang here for a long time if I use a wrong broker address.
There was a problem hiding this comment.
Is it a UI problem or a backend problem?
There was a problem hiding this comment.
Backend. From the backend log, the list opearation block(retry) for a long time.
There was a problem hiding this comment.
It's because you are listing all the topics, the default API timeout is 1 minute, should I set it to a shorter time?
There was a problem hiding this comment.
I prefer to shorten the time here.
There was a problem hiding this comment.
Should we create a new issue to track this? Since is already a list topics operation, not a create catalog issue
There was a problem hiding this comment.
Should we create a new issue to track this? Since is already a list topics operation, not a create catalog issue
Agree, a separate issue may be better.
|
Besides, you'd better change the folloing code as well. |
|
@yuqi1129 do you want to take another look? |
I have verified it, I'm okay with the changed. |
…xception more accurate (apache#3060) ### What changes were proposed in this pull request? - postpone default schema creation after admin client - reduced exception nesting ### Why are the changes needed? Fix: apache#3015 ### Does this PR introduce _any_ user-facing change? yes, when the Kafka catalog creation fails, use the correct error message ### How was this patch tested? IT added
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #3015
Does this PR introduce any user-facing change?
yes, when the Kafka catalog creation fails, use the correct error message
How was this patch tested?
IT added