[#2851] feat(core): Add relational backend for Group Entity #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. update all the modified entities.
yuqi1129
reviewed
Apr 20, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/utils/POConverters.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/UserMetaService.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/utils/POConverters.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 please take another look at this PR. |
yuqi1129
reviewed
Apr 22, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/GroupMetaService.java
Outdated
Show resolved
Hide resolved
|
@qqqttt123 |
qqqttt123
approved these changes
Apr 22, 2024
|
Thanks all. Wait for CI. |
|
We'd better modify to support storing role, user, and group under and {metalake}.system.{role|user|group}, which is aligned with kv storage, and later on if have a system catalog mechanism, we can use system catalog to show something, what do you think? @qqqttt123 @lw-yang @yuqi1129 If it requires a lot of effort, we can do it later on. |
|
@jerryshao I agree with you, it would also be aligned with other entities' relation storage. I am working on this, but i found the code is changed a lot, could i modify this after 0.5.0 release |
OK, no problem. Can you please create an issue to track this? |
|
sure, I have created an issue #3099 |
|
Merged this first. Thanks all. |
yuqi1129
added a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Add relational backend for Role Entity [note]: wait for #3031 merged first ### Why are the changes needed? Fix: #2852 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]> Co-authored-by: Qi Yu <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Add relational backend for Role Entity [note]: wait for #3031 merged first ### Why are the changes needed? Fix: #2852 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]> Co-authored-by: Qi Yu <[email protected]>
yuqi1129
added a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Add relational backend for Role Entity [note]: wait for #3031 merged first ### Why are the changes needed? Fix: #2852 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut Co-authored-by: lwyang <[email protected]> Co-authored-by: yangliwei <[email protected]> Co-authored-by: Qi Yu <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…ache#3031) ### What changes were proposed in this pull request? add relational backend for Group Entity [note]: wait for apache#2850 merged first ### Why are the changes needed? Fix: apache#2851 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…che#3065) ### What changes were proposed in this pull request? Add relational backend for Role Entity [note]: wait for apache#3031 merged first ### Why are the changes needed? Fix: apache#2852 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ut --------- Co-authored-by: yangliwei <[email protected]> Co-authored-by: Qi Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add relational backend for Group Entity
[note]: wait for #2850 merged first
Why are the changes needed?
Fix: #2851
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
ut