Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2996][#3011] fix(web): fix refresh issue and kafka topic property issue #3014

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

LauraXia123
Copy link
Collaborator

@LauraXia123 LauraXia123 commented Apr 18, 2024

What changes were proposed in this pull request?

Load catalogs first when refresh schema or table level page
image
Fix kafka topic property issue

Why are the changes needed?

Fix: #2996, Fix: #3011

Does this PR introduce any user-facing change?

When schema, table or fileset page network error, refresh the page

How was this patch tested?

image

@LauraXia123 LauraXia123 requested a review from ch3yne April 18, 2024 10:34
@ch3yne ch3yne changed the title [#2996][#3011] fix refresh issue and kafka topic property issue [#2996][#3011] fix(web): fix refresh issue and kafka topic property issue Apr 19, 2024
Copy link
Contributor

@ch3yne ch3yne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch3yne ch3yne merged commit 6c8b3c4 into apache:main Apr 19, 2024
22 checks passed
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…c property issue (apache#3014)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Load catalogs first when refresh schema or table level page
<img width="1395" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f3af84e6-d6dc-474e-9f55-e714edb9be35">
Fix kafka topic property issue

### Why are the changes needed?

Fix: apache#2996, Fix: apache#3011

### Does this PR introduce _any_ user-facing change?
When schema, table or fileset page network error, refresh the page

### How was this patch tested?
<img width="735" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d69bc9f3-d4f7-4f1e-bc2c-65941821a510">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants