[#2874] improvement(CI): remove SSH service from Hive container #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
changed the title
|
The change looks good to me. @xunliu do you want take another look? |
xunliu
reviewed
Apr 11, 2024
| @@ -4,15 +4,16 @@ | |||
| # This software is licensed under the Apache License version 2. | |||
| # | |||
|
|
|||
| # start ssh | |||
There was a problem hiding this comment.
@mchades Do we need also remove apt-get install openssh-server from `hive/Dockerfile/?
There was a problem hiding this comment.
I'm not sure if removing this service will cause other issues, this requires more testing.
I suggest keeping it for now and handling it in a separate PR if necessary.
xunliu
approved these changes
Apr 11, 2024
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
hadoop-daemon.shto start HDFS services.Why are the changes needed?
Fix: #2874
Does this PR introduce any user-facing change?
no
How was this patch tested?
CI pass