[#2610] feat(kafka-catalog, core): Adapt the Kafka catalog to CatalogOperationsDispatcher #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Mar 30, 2024
| .withComment(comment) | ||
| // Because there is no way to store the Gravitino ID in Kafka, therefor we use the topic | ||
| // ID as the Gravitino ID | ||
| .withProperties(newPropertiesWithId(convertToGravitinoId(topicId), properties)) |
There was a problem hiding this comment.
Can you please add a test for this change.
Comment on lines
+78
to
+88
| StringIdentifier stringId = getStringIdFromProperties(topic.properties()); | ||
| // Case 1: The topic is not created by Gravitino. | ||
| // Note: for Kafka catalog, stringId will not be null. Because there is no way to store the | ||
| // Gravitino | ||
| // ID in Kafka, therefor we use the topic ID as the Gravitino ID | ||
| if (stringId == null) { | ||
| return EntityCombinedTopic.of(topic) | ||
| .withHiddenPropertiesSet( | ||
| getHiddenPropertyNames( | ||
| catalogIdent, HasPropertyMetadata::topicPropertiesMetadata, topic.properties())); | ||
| } |
There was a problem hiding this comment.
This should never happened, right?
There was a problem hiding this comment.
As of now, yes.
But if other messaging catalogs that support setting topic property are implemented later, such as Pulsar, this stringId may be null.
| @@ -88,6 +88,7 @@ public <E extends Entity & HasIdentifier> void insert(E e, boolean overwritten) | |||
| } else if (e instanceof FilesetEntity) { | |||
| FilesetMetaService.getInstance().insertFileset((FilesetEntity) e, overwritten); | |||
| } else { | |||
| // TODO: Add support for TopicEntity | |||
| throw new UnsupportedEntityTypeException( | |||
| "Unsupported entity type: %s for insert operation", e.getClass()); | |||
There was a problem hiding this comment.
Are you going to do this in another PR?
There was a problem hiding this comment.
Yes, some design work may be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add the Kafka catalog adaption to the CatalogOperationsDispatcher
Why are the changes needed?
Part of Kafka catalog support work
Fix: #2610
Does this PR introduce any user-facing change?
no
How was this patch tested?
UTs