Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2651] feat(docker): optimize start.sh in Doris container #2652

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

zhoukangcn
Copy link
Contributor

@zhoukangcn zhoukangcn commented Mar 22, 2024

What changes were proposed in this pull request?

  • Optimizestartup.sh, cat log to stdout
  • Add disk space check before starting Doris
  • Exit when FE or BE start failed

Why are the changes needed?

Fix: #2651

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

UT

@zhoukangcn
Copy link
Contributor Author

@yuqi1129 could you help to review this PR when you are free.

I had build Doris container zhoukangcn/gravitino-ci-doris:0.1.1, and UT in #2597 seem worked

@zhoukangcn zhoukangcn closed this Mar 22, 2024
@zhoukangcn zhoukangcn reopened this Mar 22, 2024
@zhoukangcn zhoukangcn changed the title [#2651] fix: update Doris dockerfile & scripts, fix Doris container startup failure [#2651] fix: fix Doris container startup failure in github flow Mar 22, 2024
@zhoukangcn zhoukangcn closed this Mar 22, 2024
@zhoukangcn zhoukangcn reopened this Mar 22, 2024
@yuqi1129
Copy link
Contributor

@zhoukangcn
So, what's the root cause that prevents Dennis from starting successfully?

@@ -17,7 +17,7 @@ RUN apt-get update -y && DEBIAN_FRONTEND=noninteractive apt-get install -y --no
curl wget less vim htop iproute2 numactl jq iotop sysstat tzdata xz-utils \
tcpdump iputils-ping dnsutils strace lsof blktrace \
bpfcc-tools linux-headers-realtime linux-tools-realtime silversearcher-ag \
net-tools openjdk-8-jdk && \
net-tools netcat openjdk-8-jdk && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the change log to docker-image-details.md.

@zhoukangcn zhoukangcn changed the title [#2651] fix: fix Doris container startup failure in github flow [#2651] feat(docker): optimize start.sh in Doris container Mar 25, 2024
@zhoukangcn zhoukangcn force-pushed the fix-doris-docker branch 2 times, most recently from 57ff97f to b75c375 Compare March 26, 2024 01:25
@zhoukangcn
Copy link
Contributor Author

zhoukangcn commented Mar 26, 2024

@zhoukangcn So, what's the root cause that prevents Dennis from starting successfully?

Root Cause :

  • Doris FE (version < 2.1.0) requires at least 6G disk space
  • This limitaion cannot be modified by config (Verison < 2.1.0)
  • github workflow instance only have 5.1G after pull doris images

so, I submit another PR #2692 to fix this problem

@yuqi1129
Copy link
Contributor

It's okay with me for the change, @qqqttt123 please also help to take a look.

Copy link
Contributor

@qqqttt123 qqqttt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qqqttt123 qqqttt123 merged commit ce50754 into apache:main Mar 27, 2024
12 checks passed
@qqqttt123
Copy link
Contributor

qqqttt123 commented Mar 27, 2024

New Doris CI image is released. https://github.com/datastrato/gravitino/actions/runs/8448998039
Thanks for your great work! @zhoukangcn @yuqi1129

@zhoukangcn zhoukangcn deleted the fix-doris-docker branch March 27, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] optimize start.sh in Doris container
3 participants