[#2349] improved(scripts): Add scripts directory for jdbc backend ddl scripts #2584
Conversation
|
@jerryshao Could you take a look of this? Thanks. |
|
@yuqi1129 Please also take a look of this, thanks. |
| @@ -110,7 +110,7 @@ private void init(String type, Config config) { | |||
|
|
|||
| private void prepareJdbcTable() { | |||
| // Read the ddl sql to create table | |||
| String scriptPath = "h2/h2-init.sql"; | |||
| String scriptPath = "relational-entity-store/jdbc/h2/schema-0.5.0-h2.sql"; | |||
There was a problem hiding this comment.
What's the meaning of 0.5.0?
There was a problem hiding this comment.
This refers to the next release version. We may add some ddl statements to the new version in the future. Users can execute initialization statements according to the access version. Referring to the implementation in Hive Metastore:
|
Additionally, it appears that we lack a mechanism to verify whether the configurations of relational entity store is well-configurated at the start. Only when we are about to operate metalakes, catalogs and so on can we confirm that everything is well. Is there a good way to verify it? |
A simple way is that when we start the MySQL backend, we try to perform operations similar to |
|
@jerryshao Could you take a look of this? Thanks. |
|
Maybe we don't need to have too many folders for script, "scripts/mysql/xxx" is enough, WDYT? |
Sure, I don't have much preference for this. |
Then let's do this. |
|
Have changed like this: |
|
Finally, pass the CI, merging to main, thanks @xloya for your work. |
…2768) ### What changes were proposed in this pull request? Add user documentation for relational entity store. Depends on #2584. ### Why are the changes needed? Fix: #2348 --------- Co-authored-by: xiaojiebao <[email protected]> Co-authored-by: Jerry Shao <[email protected]>
What changes were proposed in this pull request?
Add a separate scripts directory to save the ddl sql statements that jdbc backend needs to execute.
Why are the changes needed?
Fix: #2349