[#2551] feat(catalog-jdbc-doris): Add a basic skeleton for Doris catalog #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoukangcn
force-pushed
the
f-2551
branch
2 times, most recently
from
3cef07d to
e2c4cda
Compare
mchades
reviewed
Mar 16, 2024
| testImplementation(libs.testcontainers) | ||
| testImplementation(libs.testcontainers.mysql) | ||
|
|
||
| testRuntimeOnly(libs.junit.jupiter.engine) |
There was a problem hiding this comment.
We can remove the dependencies listed above because they are not currently in use.
There was a problem hiding this comment.
If we need to remove it, I believe other dependencies like test container should also be dropped.
There was a problem hiding this comment.
@yuqi1129 yes，I had remove all test dependencies
| import com.datastrato.gravitino.exceptions.GravitinoRuntimeException; | ||
| import java.sql.SQLException; | ||
|
|
||
| /** Exception converter to gravitino exception for Doris. */ |
There was a problem hiding this comment.
same typo in MysqlExceptionConverter , i can fix it in another PR (for #2553 )
mchades
approved these changes
Mar 17, 2024
zhoukangcn
changed the title
jerryshao
approved these changes
Mar 17, 2024
coolderli
pushed a commit
to coolderli/gravitino
that referenced
this pull request
Apr 2, 2024
…s catalog (apache#2554) ### What changes were proposed in this pull request? Add a basic skeleton for Doris catalog ### Why are the changes needed? Fix: apache#2551 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? just build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a basic skeleton for Doris catalog
Why are the changes needed?
Fix: #2551
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
just build