[#1550] feat(spark-connector) support partition,bucket, sortorder table #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
force-pushed
the
partition
branch
3 times, most recently
from
c8cf9ff to
fc2770f
Compare
FANNG1
changed the title
FANNG1
force-pushed
the
partition
branch
2 times, most recently
from
3086089 to
fcbe74b
Compare
FANNG1
commented
Mar 18, 2024
...ctor/src/test/java/com/datastrato/gravitino/spark/connector/TestSparkTransformConverter.java
Outdated
Show resolved
Hide resolved
FANNG1
commented
Mar 18, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
|
It's ready to review now, @jerryshao @qqqttt123 @yuqi1129 @mchades @diqiu50 please help to review when you are free. |
yuqi1129
reviewed
Mar 18, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
spark-connector/src/main/java/com/datastrato/gravitino/spark/connector/ConnectorConstants.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Mar 18, 2024
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Mar 18, 2024
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Outdated
Show resolved
Hide resolved
FANNG1
force-pushed
the
partition
branch
2 times, most recently
from
9644609 to
d404224
Compare
caican00
reviewed
Mar 20, 2024
...k-connector/src/main/java/com/datastrato/gravitino/spark/connector/table/SparkBaseTable.java
Show resolved
Hide resolved
|
@jerryshao , please help to review when you are free, thanks |
jerryshao
reviewed
Mar 20, 2024
| @@ -27,6 +28,10 @@ dependencies { | |||
| implementation("org.apache.kyuubi:kyuubi-spark-connector-hive_$scalaVersion:$kyuubiVersion") | |||
| implementation("org.apache.spark:spark-catalyst_$scalaVersion:$sparkVersion") | |||
| implementation("org.apache.spark:spark-sql_$scalaVersion:$sparkVersion") | |||
| implementation("org.scala-lang.modules:scala-java8-compat_$scalaVersion:$scalaJava8CompatVersion") | |||
There was a problem hiding this comment.
Does it work in jdk 11 or 17?
There was a problem hiding this comment.
yes, it's A Java 8 (and up) compatibility kit for Scala. which could pass IT.
jerryshao
reviewed
Mar 20, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
mchades
reviewed
Mar 20, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
mchades
reviewed
Mar 20, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
|
split |
yuqi1129
reviewed
Mar 21, 2024
...rc/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfoChecker.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
| // Gravitino use ["a","b"] for nested fields while Spark use "a.b"; | ||
| private static String getFieldNameFromGravitinoNamedReference( | ||
| NamedReference gravitinoNamedReference) { | ||
| return String.join(ConnectorConstants.DOT, gravitinoNamedReference.fieldName()); |
There was a problem hiding this comment.
@mchades Does Gravitino support nested fields? I remember ["a","b"], a means the table reference and b is the real column name?
There was a problem hiding this comment.
No, the array of fieldName is used to represent access nested fields. For example, the column a is struct type{b int, c string}, then we can use a.b or a.c to reference a nested field
mchades
reviewed
Mar 21, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkEnvIT.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Mar 21, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Mar 22, 2024
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/spark/connector/SparkTransformConverter.java
Outdated
Show resolved
Hide resolved
| bucketNum, createSparkNamedReference(bucketFields), createSparkNamedReference(sortFields)); | ||
| } | ||
|
|
||
| // columnName could be "a" or "a.b" for nested column |
There was a problem hiding this comment.
So do you need to handle nested column case here?
There was a problem hiding this comment.
I prefer to handle it, because both spark and gravitino interfaces support nested columns
There was a problem hiding this comment.
So I don't see you do it here?
There was a problem hiding this comment.
Sorry, I see the code there, please ignore.
|
@mchades @qqqttt123 @yuqi1129 @jerryshao @diqiu50 all comments are addressed, please help to review again. |
|
I have no further comment, I think we can go to unblock other PRs. If there's missing parts. We can fix in another PR. |
jerryshao
approved these changes
Mar 22, 2024
coolderli
pushed a commit
to coolderli/gravitino
that referenced
this pull request
Apr 2, 2024
…er table (apache#2540) ### What changes were proposed in this pull request? add partition, distribution, sort order support for spark connector ### Why are the changes needed? Fix: apache#1550 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add UT and IT, also verified in local env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add partition, distribution, sort order support for spark connector
Why are the changes needed?
Fix: #1550
Does this PR introduce any user-facing change?
no
How was this patch tested?
add UT and IT, also verified in local env.