Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2379] fix(hive-ci-image): Let user hive be able to access MySQL #2523

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

charliecheng630
Copy link
Contributor

What changes were proposed in this pull request?

Let user hive be able to access MySQL in gravitino-ci-hive container.

Why are the changes needed?

Fix: #2379

Does this PR introduce any user-facing change?

No

How was this patch tested?

./build-docker.sh --platform linux/arm64 --type hive --image datastrato/gravitino-ci-hive --tag 0.1.9

dev/docker/hive/Dockerfile Outdated Show resolved Hide resolved
docs/docker-image-details.md Outdated Show resolved Hide resolved
@mchades
Copy link
Contributor

mchades commented Mar 13, 2024

@danhuawang Could you please help to test these changes in your environment, thanks!

@mchades mchades changed the title [#2379] Let user hive be able to access MySQL in gravitino-ci-hive container. [#2379] fix(hive-ci-image): Let user hive be able to access MySQL Mar 13, 2024
@danhuawang
Copy link
Contributor

@danhuawang Could you please help to test these changes in your environment, thanks!

It's ok in my test environment.

@jerryshao
Copy link
Contributor

@mchades please help to continue this PR.

@mchades
Copy link
Contributor

mchades commented Mar 14, 2024

The version of gravitino-ci-hive also need to update to 0.1.9 in build.gradle.kts(in the modules: catalog-hadoop, catalog-hive, catalog-lakehouse-iceberg, integration-test)

@mchades
Copy link
Contributor

mchades commented Mar 14, 2024

@danhuawang Could you please help to test these changes in your environment, thanks!

It's ok in my test environment.

The modified Dockfile also passed tests in my environment.

Afer @charliecheng630 address the comments, I will push the new image gravitino-ci-hive:0.1.9 and rerun tests of this PR

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution, looking forward to more in the future!

@mchades mchades merged commit 83e0e6b into apache:main Mar 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] check-status.sh run failed in gravitino-ci-hive container
4 participants