[#1339] feat(jdbc-doris): Support Apache Doris Catalog #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoukangcn
force-pushed
the
f-1339
branch
3 times, most recently
from
ec4af86 to
1b13072
Compare
|
@zhoukangcn |
|
@yuqi1129 yes, please review this PR. Thanks. |
yuqi1129
reviewed
Mar 12, 2024
| @Override | ||
| public JdbcSchema load(String databaseName) throws NoSuchSchemaException { | ||
| try (final Connection connection = this.dataSource.getConnection()) { | ||
| String query = "SELECT * FROM information_schema.SCHEMATA WHERE SCHEMA_NAME = ?"; |
There was a problem hiding this comment.
Can the user has the privilege to access system table like MySQL？
There was a problem hiding this comment.
@diqiu50 Doris is case-insensitive
There was a problem hiding this comment.
@yuqi1129 yes, user has default privilege to use database, and can list all tables.
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Outdated
Show resolved
Hide resolved
| expression -> { | ||
| Preconditions.checkArgument( | ||
| Arrays.stream(columns) | ||
| .anyMatch(column -> column.name().equalsIgnoreCase(expression.toString())), |
There was a problem hiding this comment.
So, is the Doris column name case-insensitive?
There was a problem hiding this comment.
yes, Doris column name is case-insensitive, and will convert to lowercase
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Outdated
Show resolved
Hide resolved
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Outdated
Show resolved
Hide resolved
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java
Show resolved
Hide resolved
| } else if (change instanceof TableChange.UpdateColumnType) { | ||
| lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); | ||
| TableChange.UpdateColumnType updateColumnType = (TableChange.UpdateColumnType) change; | ||
| alterSql.add(updateColumnTypeFieldDefinition(updateColumnType, lazyLoadTable)); |
There was a problem hiding this comment.
Please review the backquote issues regarding column names, table names, etc in the whole PR carefully.
diqiu50
reviewed
Mar 12, 2024
| Connection connection = DriverManager.getConnection(dorisMySQLUrl, USER_NAME, ""); | ||
|
|
||
| // execute `SHOW PROC '/backends';` to check if backends is ready | ||
| String query = "SHOW PROC '/backends';"; |
| package com.datastrato.gravitino.catalog.doris.operation; | ||
|
|
||
| /** Test class for {@link DorisTableOperations}. */ | ||
| public class TestDorisTableOperations {} |
There was a problem hiding this comment.
What is the purpose of this class?
| # jdbc-user: strato | ||
| # jdbc-password: strato | ||
| # jdbc-driver: com.mysql.jdbc.Driver | ||
| # jdbc-driver: com.mysql.cj.jdbc.Driver |
There was a problem hiding this comment.
Is this file still useful?
| } else if (type instanceof Types.VarCharType) { | ||
| return VARCHAR + "(" + ((Types.VarCharType) type).length() + ")"; | ||
| } else if (type instanceof Types.FixedCharType) { | ||
| return CHAR + "(" + ((Types.FixedCharType) type).length() + ")"; |
There was a problem hiding this comment.
How to handle the CharType length limitation?
| @Override | ||
| public JdbcSchema load(String databaseName) throws NoSuchSchemaException { | ||
| try (final Connection connection = this.dataSource.getConnection()) { | ||
| String query = "SELECT * FROM information_schema.SCHEMATA WHERE SCHEMA_NAME = ?"; |
|
|
||
| /** Table operations for Doris. */ | ||
| public class DorisTableOperations extends JdbcTableOperations { | ||
| public static final String BACK_QUOTE = "`"; |
There was a problem hiding this comment.
Similarly, does the database name require the BACK_QUOTE
zhoukangcn
force-pushed
the
f-1339
branch
9 times, most recently
from
5ed0a7d to
18d7baf
Compare
mchades
reviewed
Mar 14, 2024
| case DATE: | ||
| return Types.DateType.get(); | ||
| case DATETIME: | ||
| return Types.TimeType.get(); |
There was a problem hiding this comment.
DATETIME should convert to timestamp?
| } else if (type instanceof Types.DateType) { | ||
| return DATE; | ||
| } else if (type instanceof Types.TimeType) { | ||
| return DATETIME; |
| String databaseName, String comment, Map<String, String> properties) { | ||
| if (StringUtils.isNotEmpty(comment)) { | ||
| LOG.warn( | ||
| "Ignoring comment option on database create. doris does not support comment option on database create."); |
zhoukangcn
force-pushed
the
f-1339
branch
2 times, most recently
from
6734dca to
d146085
Compare
| public class TestDorisUtils { | ||
| @Test | ||
| public void generatePropertiesSql() { | ||
| // Test When properties is null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support Apache Doris as a type of data source.
Why are the changes needed?
Fix: #1339
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
UT & IT